Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Mon, 28 Sep 2020 15:13:53 +0200 | Subject | Re: [PATCH v2 7/9] gpio: mockup: pass the chip label as device property |
| |
On Mon, Sep 28, 2020 at 3:00 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Mon, Sep 28, 2020 at 12:41:53PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > While we do check the "chip-name" property in probe(), we never actually > > use it. Let's pass the chip label to the driver using device properties > > as we'll want to allow users to define their own once dynamically > > created chips are supported. > > > > The property is renamed to "chip-label" to not cause any confusion with > > the actual chip name which is of the form: "gpiochipX". > >
^^^ here, see below
> > If the "chip-label" property is missing, let's do what most devices in > > drivers/gpio/ do and use dev_name(). > > ... > > > + snprintf(chip_label, sizeof(chip_label), > > + "gpio-mockup-%c", i + 'A'); > > + properties[prop++] = PROPERTY_ENTRY_STRING("chip-label", > > + chip_label); > > You added new property, now count is up to 4. But at the same time > > #define GPIO_MOCKUP_MAX_PROP 4 > > how do you avoid overflow? >
I renamed the property, the previous "chip-name" is no longer used. In fact it was never used but was accounted for in GPIO_MOCKUP_MAX_PROP.
Bart
| |