Messages in this thread | | | Subject | Re: [PATCH] usb: phy: tegra: Use IS_ERR() to check and simplify code | From | Tang Bin <> | Date | Mon, 28 Sep 2020 16:47:23 +0800 |
| |
Hi all:
在 2020/9/24 18:37, Felipe Balbi 写道: > Thierry Reding <thierry.reding@gmail.com> writes: > >> On Thu, Sep 24, 2020 at 10:26:15AM +0300, Felipe Balbi wrote: >>> Tang Bin <tangbin@cmss.chinamobile.com> writes: >>> >>>> Use IS_ERR() and PTR_ERR() instead of PTR_ERR_OR_ZERO() to >>>> simplify code, avoid redundant judgements. >>>> >>>> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> >>>> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> >>> Applied for next merge window. Make sure to get this driver out of >>> drivers/usb/phy and moved into drivers/phy ASAP. >> Sergei had commented on this patch with valid concerns, see here in case >> you don't have his reply in your inbox: >> >> http://patchwork.ozlabs.org/project/linux-tegra/patch/20200910115607.11392-1-tangbin@cmss.chinamobile.com/#2526208 >> >> I agree with those concerns. This patch is broken because it will output >> the wrong error code on failure. I don't fully agree with Sergei's point >> that this patch isn't worth redoing. I do like the idiomatic error >> handling better, but I think we shouldn't be breaking the error messages >> like this. > Sure thing, dropped for now.
Sorry, it's my fault.
Thanks
Tang Bin
>
| |