Messages in this thread | | | Date | Fri, 25 Sep 2020 13:48:54 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH v3] HID: logitech-hidpp: add support for Logitech G533 headset |
| |
On Thu, 10 Sep 2020, Kamil Domański wrote:
> Hi Jiri, > I'm not sure what you mean by "proper changelog that should go to the > commitlog". > Is the commit message "HID: logitech-hidpp: add support for Logitech G533 > headset" inadequate?
That's a shortlog. But please provide also brief explanation of what the patch does and how. If I apply your patch as-is, this would have gone to the git commit as a changelog:
> > > Changelog: > > > v2: > > > - changed charging status parsing to account for invalid states > > > v3: > > > - rebased against Linux v5.7 > > > - changed variable naming in hidpp20_adc_map_status_voltage > > > to camel case > > > - corrected comment styling in hidpp_battery_get_property > > > - dropped usage of test_bit macro in hidpp20_adc_map_status_voltage > > > to avoid using `long` type > > > - added bit flag definitions in hidpp20_adc_map_status_voltage > > > > > > Signed-off-by: Kamil Domański <kamil@domanski.co>
Which is definitely not how kernel commit logs look like -- just take a look at the changelogs in the kernel git repository for inspiration.
Thanks,
-- Jiri Kosina SUSE Labs
| |