Messages in this thread | | | From | Ikjoon Jang <> | Date | Fri, 25 Sep 2020 17:11:10 +0800 | Subject | Re: [PATCH v3 5/6] spi: spi-mtk-nor: support 36bit dma addressing |
| |
On Fri, Sep 25, 2020 at 4:27 PM Chuanhong Guo <gch981213@gmail.com> wrote: >
[snip]
> > + if (sp->high_dma) { > > + writel(dma_addr >> 32, sp->base + MTK_NOR_REG_DMA_DADR_HB); > > + writel((dma_addr + length) >> 32, sp->base + MTK_NOR_REG_DMA_END_DADR_HB); > > + } > > I remembered kbuild test robot reported a warning on this on 32-bit platforms > in your v1. [0] > I don't know what's the fix for this though :( > > [0] https://marc.info/?l=linux-spi&m=159982425706940&w=2
yeah, I'm not sure how to handle this properly,
"warning: shift count >= width of type", (sp->high_dma) is always false on 32bit arm kernel. I think adding size check on here is unnecessary, should I fix for this warning?
> -- > Regards, > Chuanhong Guo
Sorry for resending, Chuanhong.
| |