Messages in this thread | | | Subject | Re: [PATCH] drm/hisilicon: Deleted the drm_device declaration | From | "tiantao (H)" <> | Date | Fri, 25 Sep 2020 15:48:49 +0800 |
| |
在 2020/9/25 15:26, Thomas Zimmermann 写道: > Hi > > Am 25.09.20 um 09:02 schrieb Thomas Zimmermann: >> Hi, >> >> just a few nits. >> >> Am 25.09.20 um 08:49 schrieb Tian Tao: >>> drm_framebuffer.h contains drm/drm_device.h and struct drm_device is >> >> contains -> includes >> >>> already declared in this file, so there is no need to declare struct >> >> declared -> defined > > Wait a second. drm_framebuffer.h actually declares struct drm_device, > but does not include <drm/device.h>. So the commit messag should say > something like > > drm_framebuffer.h already declares struct drm_device, so there's no > need to declare it in hibm_drm_drv.h > Thank you very much.I will apply this. >> >>> drm_device in hibm_drm_drv.h. >>> >>> Signed-off-by: Tian Tao <tiantao6@hisilicon.com> >> >> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> >> >>> --- >>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h >>> index 87d2aad..6a63502 100644 >>> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h >>> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h >>> @@ -22,8 +22,6 @@ >>> #include <drm/drm_fb_helper.h> >>> #include <drm/drm_framebuffer.h> >>> >>> -struct drm_device; >>> - >>> struct hibmc_connector { >>> struct drm_connector base; >>> >>> >> >
| |