Messages in this thread | | | Date | Fri, 25 Sep 2020 14:16:14 -0700 | From | Kees Cook <> | Subject | Re: [PATCHv5 kselftest next] selftests/run_kselftest.sh: make each test individually selectable |
| |
On Fri, Sep 25, 2020 at 01:51:53PM +0530, Naresh Kamboju wrote: > On Mon, 14 Sep 2020 at 07:53, Hangbin Liu <liuhangbin@gmail.com> wrote: > > > > Currently, after generating run_kselftest.sh, there is no way to choose > > which test we could run. All the tests are listed together and we have > > to run all every time. This patch enhanced the run_kselftest.sh to make > > the tests individually selectable. e.g. > > > > $ ./run_kselftest.sh -t "bpf size timers" > > My test run break on linux next > > ./run_kselftest.sh: line 1331: syntax error near unexpected token `)' > ./run_kselftest.sh: line 1331: `-e -s | --summary ) > logfile=$BASE_DIR/output.log; cat /dev/null > $logfile; shift ;;'
Yes, please revert this patch. The resulting script is completely trashed:
BASE_DIR=$(realpath $(dirname $0)) . ./kselftest/runner.sh TESTS="seccomp"
run_seccomp() { -e [ -w /dev/kmsg ] && echo "kselftest: Running tests in seccomp" >> /dev/kmsg -e cd seccomp -en run_many \ -ne "seccomp_bpf" \ -ne "seccomp_benchmark"
-e cd $ROOT }
-- Kees Cook
| |