Messages in this thread | | | Date | Thu, 24 Sep 2020 17:07:48 +0100 | From | Ionela Voinescu <> | Subject | Re: [PATCH 1/3] sched/topology,schedutil: wrap sched domains rebuild |
| |
Hey,
On Thursday 24 Sep 2020 at 14:34:46 (+0100), Quentin Perret wrote: > On Thursday 24 Sep 2020 at 13:39:35 (+0100), Ionela Voinescu wrote: > > @@ -433,6 +437,7 @@ static bool build_perf_domains(const struct cpumask *cpu_map) > > } > > #else > > static void free_pd(struct perf_domain *pd) { } > > +void rebuild_sched_domains_energy(void) { } > > Nit: maybe make that stub static inline in a header instead? I guess LTO > and friends ought to clean that up for you, but it shouldn't hurt to give > the compiler a little bit of help here. >
Makes sense and will do!
Thank you, Ionela.
> Otherwise, LGTM: > > Acked-by: Quentin Perret <qperret@google.com> > > > #endif /* CONFIG_ENERGY_MODEL && CONFIG_CPU_FREQ_GOV_SCHEDUTIL*/ > > > > static void free_rootdomain(struct rcu_head *rcu) > > -- > > 2.17.1 > >
| |