Messages in this thread | | | Date | Thu, 24 Sep 2020 16:47:09 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] mm/hmm/test: use after free in dmirror_allocate_chunk() |
| |
On Tue, Sep 22, 2020 at 10:31:01AM -0700, Ralph Campbell wrote: > > @@ -471,30 +487,16 @@ static bool dmirror_allocate_chunk(struct dmirror_device *mdevice, > > sizeof(new_chunks[0]) * new_capacity, > > GFP_KERNEL); > > if (!new_chunks) > > Need to call mutex_unlock(&mdevice->devmem_lock). > In fact, why not make this goto err_unlock and add > err_unlock: mutex_unlock() before the err_release:.
Ugh... Thanks for catching that.
regards, dan carpenter
| |