Messages in this thread | | | Date | Thu, 24 Sep 2020 22:42:07 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH] drm/stm: dsi: Avoid printing errors for -EPROBE_DEFER |
| |
Hi Yannick
On Fri, Sep 18, 2020 at 01:46:24PM +0200, Yannick Fertre wrote: > Don't print error when probe deferred error is returned. > > Signed-off-by: Yannick Fertre <yannick.fertre@st.com> > --- > drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c > index 2e1f2664495d..164f79ef6269 100644 > --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c > +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c > @@ -419,7 +419,8 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev) > dsi->dsi = dw_mipi_dsi_probe(pdev, &dw_mipi_dsi_stm_plat_data); > if (IS_ERR(dsi->dsi)) { > ret = PTR_ERR(dsi->dsi); > - DRM_ERROR("Failed to initialize mipi dsi host: %d\n", ret); > + if (ret != -EPROBE_DEFER) > + DRM_ERROR("Failed to initialize mipi dsi host: %d\n", ret); > goto err_dsi_probe;
Please use dev_err_probe() here. We will loose [drm] but gain more than we loose.
Sam
> } > > -- > 2.17.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
| |