Messages in this thread | | | Date | Thu, 24 Sep 2020 16:33:31 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 1/2] tracepoints: Add helper to test if tracepoint is enabled in a header |
| |
On Thu, 24 Sep 2020 16:27:34 -0400 (EDT) Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> I'd be a bit more specific: so far, the msr.h use-case requires to include > directly tracepoint-defs.h and use a tracepoint_enabled() macro defined there. > > Other less "core" header use-cases could still include tracepoint.h, as long as > there is no circular dependency.
Well, I'll keep tracepoint-defs.h for the msr.h case, and I could see if tracepoint.h is good enough for the other cases.
But does it really matter, if we only need what is in tracepoint-defs.h? Why add something that may cause issues in the future?
-- Steve
| |