Messages in this thread | | | Subject | Re: [PATCH v2 2/3] KVM: VMX: Replace MSR_IA32_RTIT_OUTPUT_BASE_MASK with helper function | From | Paolo Bonzini <> | Date | Wed, 23 Sep 2020 19:07:22 +0200 |
| |
On 23/09/20 18:36, Sean Christopherson wrote: > +static inline bool pt_output_base_valid(struct kvm_vcpu *vcpu, u64 base) > +{ > + /* The base must be 128-byte aligned and a legal physical address. */ > + return !(base & (~((1UL << cpuid_maxphyaddr(vcpu)) - 1) | 0x7f)); > +}
The fact that you deemed a comment necessary says something already. :) What about:
return !kvm_mmu_is_illegal_gpa(vcpu, base) && !(base & 0x7f);
(where this new usage makes it obvious that mmu should have been vcpu).
Paolo
| |