Messages in this thread | | | Date | Wed, 23 Sep 2020 11:05:05 -0500 | From | Yazen Ghannam <> | Subject | Re: [PATCH v2 6/8] x86/MCE/AMD: Drop tmp variable in translation code |
| |
On Wed, Sep 23, 2020 at 10:05:56AM +0200, Borislav Petkov wrote: > On Thu, Sep 03, 2020 at 08:01:42PM +0000, Yazen Ghannam wrote: > > From: Yazen Ghannam <yazen.ghannam@amd.com> > > > > Remove the "tmp" variable used to save register values. Save the values > > in existing variables, if possible. > > > > The register values are 32 bits. Use separate "reg_" variables to hold > > the register values if the existing variable sizes doesn't match, or if > > no bitfields in a register share the same name as the register. > > So I'm missing the "why" in the commit message. Why are you doing this? > > Is there some reason which I'll find out later? If not, then this is > just unnecessary churn. >
I don't have a strong reason other than trying to address a comment in the first version. I can drop this patch if you prefer.
Thanks, Yazen
| |