Messages in this thread | | | Date | Tue, 22 Sep 2020 14:40:59 +0800 | From | Shawn Guo <> | Subject | Re: [PATCH v2 1/4] ARM: dts: imx6qdl-gw5xxx: correct interrupt flags |
| |
On Thu, Sep 17, 2020 at 08:54:46PM +0200, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING > > Correct the interrupt flags, assuming the author of the code wanted same > logical behavior behind the name "ACTIVE_xxx", this is: > ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied all, thanks.
| |