Messages in this thread | | | Subject | Re: [PATCH v6 04/12] KVM: SVM: Modify intercept_exceptions to generic intercepts | From | Paolo Bonzini <> | Date | Tue, 22 Sep 2020 15:39:21 +0200 |
| |
On 14/09/20 17:06, Sean Christopherson wrote: >> I think these should take a vector instead, and add 64 in the functions. > > And "s/int bit/u32 vector" + BUILD_BUG_ON(vector > 32)?
Not sure if we can assume it to be constant, but WARN_ON_ONCE is good enough as far as performance is concerned. The same int->u32 + WARN_ON_ONCE should be done in patch 1.
Thanks for the review!
Paolo
| |