lkml.org 
[lkml]   [2020]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/5] mm: Rework return value for copy_one_pte()
    On 09/21, Peter Xu wrote:
    >
    > @@ -866,13 +877,18 @@ static int copy_pte_range(struct mm_struct *dst_mm, struct mm_struct *src_mm,
    > pte_unmap_unlock(orig_dst_pte, dst_ptl);
    > cond_resched();
    >
    > - if (entry.val) {
    > - if (add_swap_count_continuation(entry, GFP_KERNEL) < 0)
    > + switch (copy_ret) {
    > + case COPY_MM_SWAP_CONT:
    > + if (add_swap_count_continuation(data.entry, GFP_KERNEL) < 0)
    > return -ENOMEM;
    > - progress = 0;
    > + break;

    Note that you didn't clear copy_ret, it is still COPY_MM_SWAP_CONT,

    > + default:
    > + break;
    > }
    > +
    > if (addr != end)
    > goto again;

    After that the main loop can stop again because of need_resched(), and
    in this case add_swap_count_continuation(data.entry) will be called again?

    Oleg.

    \
     
     \ /
      Last update: 2020-09-22 12:09    [W:2.390 / U:0.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site