lkml.org 
[lkml]   [2020]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 4/9 next] fs/io_uring Don't use the return value from import_iovec().
On Tue, Sep 15, 2020 at 02:55:20PM +0000, David Laight wrote:
>
> This is the only code that relies on import_iovec() returning
> iter.count on success.
> This allows a better interface to import_iovec().

This looks generall sane, but a comment below:

> @@ -3123,7 +3123,7 @@ static int io_read(struct io_kiocb *req, bool force_nonblock,
> if (ret < 0)
> return ret;
> iov_count = iov_iter_count(iter);
> - io_size = ret;
> + io_size = iov_count;
> req->result = io_size;
> ret = 0;
>
> @@ -3246,7 +3246,7 @@ static int io_write(struct io_kiocb *req, bool force_nonblock,
> if (ret < 0)
> return ret;
> iov_count = iov_iter_count(iter);
> - io_size = ret;
> + io_size = iov_count;
> req->result = io_size;

I tink the local iov_count variable can go away in both functions,
as io_size only changes after the last use of iov_count (io_read) or
not at all (io_write).

\
 
 \ /
  Last update: 2020-09-21 16:16    [W:0.072 / U:1.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site