Messages in this thread | | | Date | Mon, 21 Sep 2020 15:56:25 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH printk v4 2/3] printk: move dictionary keys to dev_printk_info |
| |
On Mon 2020-09-21 13:24:45, John Ogness wrote: > Dictionaries are only used for SUBSYSTEM and DEVICE properties. The > current implementation stores the property names each time they are > used. This requires more space than otherwise necessary. Also, > because the dictionary entries are currently considered optional, > it cannot be relied upon that they are always available, even if the > writer wanted to store them. These issues will increase should new > dictionary properties be introduced. > > Rather than storing the subsystem and device properties in the > dict ring, introduce a struct dev_printk_info with separate fields > to store only the property values. Embed this struct within the > struct printk_info to provide guaranteed availability. > > Signed-off-by: John Ogness <john.ogness@linutronix.de> > Reviewed-by: Petr Mladek <pmladek@suse.com> > --- > Sorry. v3 did not include Petr's fixup correctly. @size was wrong. > Now it is correct.
I could confirm that the added line and the patch looks fine now.
Best Regards, Petr
| |