lkml.org 
[lkml]   [2020]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v7 09/34] i2c: tegra: Use reset_control_reset()
    Date
    On Wed, 09 Sep 2020 01:39:41 +0300, Dmitry Osipenko wrote:
    > Use a single reset_control_reset() instead of assert/deasset couple in
    > order to make code cleaner a tad. Note that the reset_control_reset()
    > uses 1 microsecond delay instead of 2 that was used previously, but this
    > shouldn't matter because one microsecond is a default reset time for most
    > of Tegra peripherals and TRM doesn't mention anything special in regards
    > to I2C controller's reset propagation time.
    >
    > In addition don't ignore potential error of the reset control by emitting
    > a noisy warning if it fails, which will indicate an existence of a severe
    > problem, while still allow machine to boot up.
    >
    > Reviewed-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
    > Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
    > Acked-by: Thierry Reding <treding@nvidia.com>
    > ---
    > drivers/i2c/busses/i2c-tegra.c | 13 ++++++++++---
    > 1 file changed, 10 insertions(+), 3 deletions(-)

    Tested-by: Thierry Reding <treding@nvidia.com>

    \
     
     \ /
      Last update: 2020-09-21 12:25    [W:2.824 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site