lkml.org 
[lkml]   [2020]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v7 20/34] i2c: tegra: Remove "dma" variable from tegra_i2c_xfer_msg()
    Date
    On Wed, 09 Sep 2020 01:39:52 +0300, Dmitry Osipenko wrote:
    > The "dma" variable of tegra_i2c_xfer_msg() function doesn't bring much in
    > regards to readability and generation of the code.
    >
    > Besides readability, it's also not very nice that the is_curr_dma_xfer
    > is initialized in tegra_i2c_xfer_msg() and then could be overridden by
    > tegra_i2c_config_fifo_trig(). In a result, the "dma" variable creates
    > slight confusion since it's not instantly obvious why it's set after
    > tegra_i2c_config_fifo_trig().
    >
    > Hence should be better to have the variable removed. This makes code
    > more consistent.
    >
    > Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
    > Acked-by: Thierry Reding <treding@nvidia.com>
    > ---
    > drivers/i2c/busses/i2c-tegra.c | 17 ++++++++---------
    > 1 file changed, 8 insertions(+), 9 deletions(-)

    Tested-by: Thierry Reding <treding@nvidia.com>

    \
     
     \ /
      Last update: 2020-09-21 12:20    [W:5.406 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site