lkml.org 
[lkml]   [2020]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] objtool: check: Handle calling non-function symbols in other sections
From
Date


On 9/18/20 9:07 PM, Josh Poimboeuf wrote:
> On Tue, Sep 15, 2020 at 08:53:18AM +0100, Julien Thierry wrote:
>> Relocation for a call destination could point to a symbol that has
>> type STT_NOTYPE.
>
> Then shouldn't the callee be changed to STT_FUNC?
>

Not if it's a code symbol that does not follow standard calling convention.

It's really the same case as the !reloc, except this time it's in a
different .text section. In arm64 there are different sections that are
used (.text for basic code, .idmap.text for code mapped in a manner
where virtual address == physical address, .hyp.text for kvm priviledged
code, .tramp.text for trampolines...). There aren't many cases, but some
symbols reference symbols in other sections, but the symbol being called
isn't a proper function.



--
Julien Thierry

\
 
 \ /
  Last update: 2020-09-21 11:56    [W:0.084 / U:0.720 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site