lkml.org 
[lkml]   [2020]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] KVM: x86: fix MSR_IA32_TSC read for nested migration
From
Date
On Thu, 2020-09-17 at 09:14 -0700, Sean Christopherson wrote:
> On Thu, Sep 17, 2020 at 02:07:23PM +0300, Maxim Levitsky wrote:
> > + * Intel PRM states that MSR_IA32_TSC read adds the TSC offset
>
> One more nit, "Intel SDM" would be preferred as that's most commonly used in
> KVM changelogs, and there are multiple PRM acronyms in Intel's dictionary
> these days.
Fixed.

Best regards,
Maxim Levitsky

>
> > + * even when not intercepted. AMD manual doesn't define this
> > + * but appears to behave the same
> > + *
> > + * However when userspace wants to read this MSR, return its
> > + * real L1 value so that its restore will be correct
> > + *
> > + */
> > + if (msr_info->host_initiated)
> > + msr_info->data = kvm_read_l1_tsc(vcpu, rdtsc());
> > + else
> > + msr_info->data = kvm_read_l2_tsc(vcpu, rdtsc());
> > break;
> > case MSR_MTRRcap:
> > case 0x200 ... 0x2ff:
> > --
> > 2.26.2
> >


\
 
 \ /
  Last update: 2020-09-21 11:28    [W:0.244 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site