Messages in this thread | | | Subject | Re: [PATCH v3 9/9] drm/mediatek: reduce clear event | From | Matthias Brugger <> | Date | Mon, 21 Sep 2020 18:36:45 +0200 |
| |
On 09/07/2020 04:39, Bibby Hsieh wrote: > Hi, Dennis, > > Thanks for this patch. > > It's better to send another tree for this patch. > Because this tree is only for soc/mediatek. > > Please do not forget to add the dependency information.
Normally you are right. This time I took this patch as well into my tree. I verified with the merge tag from CKs DRM tree that we don't have any conflicts, so we should be Ok.
Regards, Matthias
> > Bibby > > On Tue, 2020-07-07 at 23:45 +0800, Dennis YC Hsieh wrote: >> No need to clear event again since event always clear before wait. >> This fix depend on patch: >> "soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api" >> >> Fixes: 2f965be7f9008 ("drm/mediatek: apply CMDQ control flow") >> Signed-off-by: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com> > > Reviewed-by: Bibby Hsieh <bibby.hsieh@mediatek.com> > >> --- >> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c >> index c84e7a14d4a8..ba6cf956b239 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c >> +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c >> @@ -490,7 +490,7 @@ static void mtk_drm_crtc_hw_config(struct mtk_drm_crtc *mtk_crtc) >> mbox_flush(mtk_crtc->cmdq_client->chan, 2000); >> cmdq_handle = cmdq_pkt_create(mtk_crtc->cmdq_client, PAGE_SIZE); >> cmdq_pkt_clear_event(cmdq_handle, mtk_crtc->cmdq_event); >> - cmdq_pkt_wfe(cmdq_handle, mtk_crtc->cmdq_event, true); >> + cmdq_pkt_wfe(cmdq_handle, mtk_crtc->cmdq_event, false); >> mtk_crtc_ddp_config(crtc, cmdq_handle); >> cmdq_pkt_finalize(cmdq_handle); >> cmdq_pkt_flush_async(cmdq_handle, ddp_cmdq_cb, cmdq_handle); >
| |