lkml.org 
[lkml]   [2020]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 05/11] kvm: arm64: Remove hyp_adr/ldr_this_cpu
Hi Will,

> Cosmetic, but I think it would be cleaner just to define two variants of the
> macro here:
>
> #if defined(__KVM_NVHE_HYPERVISOR__) || defined(__KVM_VHE_HYPERVISOR__)
> .macro this_cpu_offset, dst
> mrs \dst, tpidr_el2
> .endm
> #else
> .macro this_cpu_offset, dst
> alternative_if_not ARM64_HAS_VIRT_HOST_EXTN
> mrs \dst, tpidr_el1
> alternative_else
> mrs \dst, tpidr_el2
> alternative_endif
> .endm
> #endif

Sure.

> (and should we have a shorthand __HYPERVISOR define to avoid the NVHE || VHE
> logic?)

Happy to add this but let's agree on the details.
* name: just __HYPERVISOR or __KVM_HYPERVISOR__?
* defined where? I'm wary of defining it in a header file because then sombody
will forget to add it and 'ifdef HYP' will be skipped. So I'd put this as
another '-D__HYPERVISOR' in the build rules. Do you agree?

David

\
 
 \ /
  Last update: 2020-09-21 16:55    [W:2.446 / U:0.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site