Messages in this thread | | | From | Clément Péron <> | Date | Sun, 20 Sep 2020 23:32:03 +0200 | Subject | Re: [PATCH v3 05/19] ASoc: sun4i-i2s: Add 20 and 24 bit support |
| |
Hi Samuel,
On Sun, 20 Sep 2020 at 20:45, Samuel Holland <samuel@sholland.org> wrote: > > On 9/20/20 1:07 PM, Clément Péron wrote: > > From: Marcus Cooper <codekipper@gmail.com> > > > > Extend the functionality of the driver to include support of 20 and > > 24 bits per sample. > > > > Signed-off-by: Marcus Cooper <codekipper@gmail.com> > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > Acked-by: Maxime Ripard <mripard@kernel.org> > > --- > > sound/soc/sunxi/sun4i-i2s.c | 11 +++++++++-- > > 1 file changed, 9 insertions(+), 2 deletions(-) > > > As I have mentioned before, if you want to support a 32-bit slot width on sun4i > variants (which patch 2 does via TDM and this patch does via PCM format), you > need to fix sun4i_i2s_get_wss() to return "3", not "4", for a 32-bit input.
Sorry I didn't get it the first time.
Is using a switch case is a correct solution?
static s8 sun4i_i2s_get_wss(const struct sun4i_i2s *i2s, int width) { switch (width) { case 16: return 0x0; case 20: return 0x1; case 24: return 0x2; case 32: return 0x3; }
return -EINVAL; }
Clement
> > Cheers, > Samuel
| |