Messages in this thread | | | From | Robert Marko <> | Date | Sun, 20 Sep 2020 16:18:11 +0200 | Subject | Re: [PATCH v3 2/2] net: mdio-ipq4019: add Clause 45 support |
| |
On Sun, Sep 20, 2020 at 2:19 AM Andrew Lunn <andrew@lunn.ch> wrote: > > > + > > +/* 0 = Clause 22, 1 = Clause 45 */ > > +#define MDIO_MODE_BIT BIT(8) > > How about calling this MDIO_MODE_C45
Good idea, will rename it.
> > > + /* Enter Clause 45 mode */ > > + data = readl(priv->membase + MDIO_MODE_REG); > > + > > + data |= MDIO_MODE_BIT; > > + > > + writel(data, priv->membase + MDIO_MODE_REG); > > It then becomes clearer what this does. > > Otherwise this looks O.K. > > Andrew
v4 has been pushed to address your comment Regards, Robert
| |