lkml.org 
[lkml]   [2020]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/14] pch_uart: drop double zeroing
    On Sun, Sep 20, 2020 at 01:26:13PM +0200, Julia Lawall wrote:
    > sg_init_table zeroes its first argument, so the allocation of that argument
    > doesn't have to.
    >
    > the semantic patch that makes this change is as follows:
    > (http://coccinelle.lip6.fr/)
    >
    > // <smpl>
    > @@
    > expression x,n,flags;
    > @@
    >
    > x =
    > - kcalloc
    > + kmalloc_array
    > (n,sizeof(struct scatterlist),flags)
    > ...
    > sg_init_table(x,n)
    > // </smpl>
    >
    > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

    It inits the first entry in the array, but what about all of the other
    ones? Is that "safe" to have uninitialized data in them like your
    change causes to happen?

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2020-09-20 14:14    [W:2.680 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site