Messages in this thread Patch in this message | | | Date | Wed, 2 Sep 2020 11:12:47 +0200 | From | peterz@infradea ... | Subject | Re: [PATCH v2 10/11] lockdep: Only trace IRQ edges |
| |
On Wed, Sep 02, 2020 at 11:09:35AM +0200, peterz@infradead.org wrote: > On Tue, Sep 01, 2020 at 09:21:37PM -0700, Guenter Roeck wrote: > > [ 0.000000] WARNING: CPU: 0 PID: 0 at kernel/locking/lockdep.c:4875 check_flags.part.39+0x280/0x2a0 > > [ 0.000000] DEBUG_LOCKS_WARN_ON(lockdep_hardirqs_enabled()) > > > [ 0.000000] [<00000000004cff18>] lock_acquire+0x218/0x4e0 > > [ 0.000000] [<0000000000d740c8>] _raw_spin_lock+0x28/0x40 > > [ 0.000000] [<00000000009870f4>] p1275_cmd_direct+0x14/0x60 > > Lol! yes, I can see that going side-ways... let me poke at that.
I suspect this will do.
diff --git a/arch/sparc/prom/p1275.c b/arch/sparc/prom/p1275.c index 889aa602f8d8..7cfe88e30b52 100644 --- a/arch/sparc/prom/p1275.c +++ b/arch/sparc/prom/p1275.c @@ -38,7 +38,7 @@ void p1275_cmd_direct(unsigned long *args) unsigned long flags;
local_save_flags(flags); - local_irq_restore((unsigned long)PIL_NMI); + arch_local_irq_restore((unsigned long)PIL_NMI); raw_spin_lock(&prom_entry_lock);
prom_world(1);
| |