lkml.org 
[lkml]   [2020]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 0/4] user space client interface driver
From
Date
Hi Jeff and Mani,
On 8/5/20 11:40 PM, Hemant Kumar wrote:
> V5:
> - Removed mhi_uci_drv structure.
> - Used idr instead of creating global list of uci devices.
> - Used kref instead of local ref counting for uci device and
> open count.
> - Removed unlikely macro.
>
> V4:
> - Fix locking to protect proper struct members.
> - Updated documentation describing uci client driver use cases.
> - Fixed uci ref counting in mhi_uci_open for error case.
> - Addressed style related review comments.
>
> V3: Added documentation for MHI UCI driver.
>
> V2: Added mutex lock to prevent multiple readers to access same
> mhi buffer which can result into use after free.
>
> Hemant Kumar (4):
> bus: mhi: core: Add helper API to return number of free TREs
> bus: mhi: core: Move MHI_MAX_MTU to external header file
> docs: Add documentation for userspace client interface
> bus: mhi: clients: Add userspace client interface driver
>
> Documentation/mhi/index.rst | 1 +
> Documentation/mhi/uci.rst | 39 +++
> drivers/bus/mhi/Kconfig | 6 +
> drivers/bus/mhi/Makefile | 1 +
> drivers/bus/mhi/clients/Kconfig | 15 +
> drivers/bus/mhi/clients/Makefile | 3 +
> drivers/bus/mhi/clients/uci.c | 662 +++++++++++++++++++++++++++++++++++++++
> drivers/bus/mhi/core/internal.h | 1 -
> drivers/bus/mhi/core/main.c | 12 +
> include/linux/mhi.h | 12 +
> 10 files changed, 751 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/mhi/uci.rst
> create mode 100644 drivers/bus/mhi/clients/Kconfig
> create mode 100644 drivers/bus/mhi/clients/Makefile
> create mode 100644 drivers/bus/mhi/clients/uci.c
>

Could you please review my changes on V5? I tried addressing Greg's
comment and would need help getting it reviewed from other contributors
to MHI driver as well.

Thanks,
Hemant
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

\
 
 \ /
  Last update: 2020-09-02 22:32    [W:0.123 / U:1.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site