Messages in this thread | | | Date | Sat, 19 Sep 2020 11:44:18 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v5 1/3] leds: pwm: Remove platform_data support |
| |
Hi!
> Since commit 141f15c66d94 ("leds: pwm: remove header") that platform > interface is not usable from outside and there seems to be no in tree > user anymore. All in-tree users of the leds-pwm driver seem to use DT > currently. Getting rid of the old platform interface will allow the > leds-pwm driver to switch over from 'devm_led_classdev_register()' to > 'devm_led_classdev_register_ext()' later.
> @@ -61,6 +56,7 @@ static int led_pwm_set(struct led_classdev *led_cdev, > return pwm_apply_state(led_dat->pwm, &led_dat->pwmstate); > } > > +__attribute__((nonnull)) > static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, > struct led_pwm *led, struct fwnode_handle *fwnode) > {
This normally goes elsewhere -- right? I'd expect:
static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, struct led_pwm *led, struct fwnode_handle *fwnode) __attribute__((nonnull))
Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |