lkml.org 
[lkml]   [2020]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] scsi: arcmsr: Remove the superfluous break
From
Date
On 9/18/20 11:13 AM, Joe Perches wrote:
> On Fri, 2020-09-18 at 09:56 -0500, Gustavo A. R. Silva wrote:
>> On Fri, Sep 18, 2020 at 05:32:30PM +0800, Jing Xiangfeng wrote:
>>> Remove the superfluous break, as there is a 'return' before it.
>>>
>>
>> Apparently, the change is correct. Please, just add a proper Fixes tag by
>> yourself this time.
>
> There's no need for a "Fixes:" here, it's purely cosmetic.
>
> btw:
>
> There are at least 150 instances of
> return foo(...);
> break;
> still in the kernel tree:

A lot of these are false positives, since they follow a pattern of:

if (some_condition)
return func();
break;

--
Jens Axboe

\
 
 \ /
  Last update: 2020-09-18 19:19    [W:0.242 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site