Messages in this thread | | | Subject | Re: [PATCH] ocxl: fix kconfig dependency warning for OCXL | From | Frederic Barrat <> | Date | Fri, 18 Sep 2020 17:12:26 +0200 |
| |
Le 18/09/2020 à 11:41, Necip Fazil Yildiran a écrit : > When OCXL is enabled and HOTPLUG_PCI is disabled, it results in the > following Kbuild warning: > > WARNING: unmet direct dependencies detected for HOTPLUG_PCI_POWERNV > Depends on [n]: PCI [=y] && HOTPLUG_PCI [=n] && PPC_POWERNV [=y] && EEH [=y] > Selected by [y]: > - OCXL [=y] && PPC_POWERNV [=y] && PCI [=y] && EEH [=y] > > The reason is that OCXL selects HOTPLUG_PCI_POWERNV without depending on > or selecting HOTPLUG_PCI while HOTPLUG_PCI_POWERNV is subordinate to > HOTPLUG_PCI. > > HOTPLUG_PCI_POWERNV is a visible symbol with a set of dependencies. > Selecting it will lead to overlooking its other dependencies as well. > > Let OCXL depend on HOTPLUG_PCI_POWERNV instead to avoid Kbuild issues. > > Fixes: 49ce94b8677c ("ocxl: Add PCI hotplug dependency to Kconfig") > Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com> > ---
OK, that makes sense, thanks! Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
> drivers/misc/ocxl/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/misc/ocxl/Kconfig b/drivers/misc/ocxl/Kconfig > index 6551007a066c..947294f6d7f4 100644 > --- a/drivers/misc/ocxl/Kconfig > +++ b/drivers/misc/ocxl/Kconfig > @@ -9,9 +9,8 @@ config OCXL_BASE > > config OCXL > tristate "OpenCAPI coherent accelerator support" > - depends on PPC_POWERNV && PCI && EEH > + depends on PPC_POWERNV && PCI && EEH && HOTPLUG_PCI_POWERNV > select OCXL_BASE > - select HOTPLUG_PCI_POWERNV > default m > help > Select this option to enable the ocxl driver for Open >
| |