Messages in this thread | | | Subject | Re: [PATCH v1 1/3] bus: mhi: core: Remove warnings for missing MODULE_LICENSE() | From | Jeffrey Hugo <> | Date | Fri, 18 Sep 2020 08:27:30 -0600 |
| |
On 9/17/2020 4:19 PM, Bhaumik Bhatt wrote: > When building MHI as a module, missing MODULE_LICENSE() warnings > are seen. Avoid them by adding the license and description > information for the files where the warnings are seen. > > Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org> > --- > drivers/bus/mhi/core/boot.c | 3 +++ > drivers/bus/mhi/core/main.c | 3 +++ > drivers/bus/mhi/core/pm.c | 3 +++ > 3 files changed, 9 insertions(+) > > diff --git a/drivers/bus/mhi/core/boot.c b/drivers/bus/mhi/core/boot.c > index 24422f5..78140cc 100644 > --- a/drivers/bus/mhi/core/boot.c > +++ b/drivers/bus/mhi/core/boot.c > @@ -523,3 +523,6 @@ void mhi_fw_load_handler(struct mhi_controller *mhi_cntrl) > error_alloc_fw_table: > release_firmware(firmware); > } > + > +MODULE_LICENSE("GPL v2"); > +MODULE_DESCRIPTION("MHI Host Interface"); > diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c > index 2cff5dd..172026f 100644 > --- a/drivers/bus/mhi/core/main.c > +++ b/drivers/bus/mhi/core/main.c > @@ -1533,3 +1533,6 @@ int mhi_poll(struct mhi_device *mhi_dev, u32 budget) > return ret; > } > EXPORT_SYMBOL_GPL(mhi_poll); > + > +MODULE_LICENSE("GPL v2"); > +MODULE_DESCRIPTION("MHI Host Interface"); > diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c > index ce4d969..72c3dbc 100644 > --- a/drivers/bus/mhi/core/pm.c > +++ b/drivers/bus/mhi/core/pm.c > @@ -1150,3 +1150,6 @@ void mhi_device_put(struct mhi_device *mhi_dev) > read_unlock_bh(&mhi_cntrl->pm_lock); > } > EXPORT_SYMBOL_GPL(mhi_device_put); > + > +MODULE_LICENSE("GPL v2"); > +MODULE_DESCRIPTION("MHI Host Interface"); >
I would expect you only need to add the MODULE_* once per module, in which case main.c is probably the only place that needs it.
-- Jeffrey Hugo Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
| |