lkml.org 
[lkml]   [2020]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 2/5] spi: spi-mtk-nor: fix mishandled logics in checking SPI memory operation
    Hi!

    On Fri, Sep 18, 2020 at 9:09 PM Chuanhong Guo <gch981213@gmail.com> wrote:
    > On Fri, Sep 18, 2020 at 4:34 PM Ikjoon Jang <ikjn@chromium.org> wrote:
    > > [...]
    > > + switch (op->data.dir) {
    > > + case SPI_MEM_DATA_IN:
    > > + if (!mtk_nor_match_read(op))
    > > + return -EINVAL;
    >
    > You are changing the code logic here.
    > mtk_nor_match_read checks if the operation can be executed
    > using controller PIO/DMA reading. Even if it's not supported,
    > we can still use PRG mode to execute the operation.
    > One example of such an operation is SPI NOR SFDP reading.
    > Your change breaks that which then breaks 1_2_2 and 1_4_4
    > reading capability because spi-nor driver parses these op formats
    > from SFDP table.

    I just noticed that you already broke this in:
    spi: spi-mtk-nor: support standard spi properties
    Please also fix the same logic in mtk_nor_supports_op in your v3.

    --
    Regards,
    Chuanhong Guo

    \
     
     \ /
      Last update: 2020-09-18 15:34    [W:4.204 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site