Messages in this thread | | | Subject | Re: [PATCH v2] EDAC/mc_sysfs: Add missing newlines when printing {max,dimm}_location | From | Joe Perches <> | Date | Fri, 18 Sep 2020 06:31:04 -0700 |
| |
On Fri, 2020-09-18 at 09:12 +0200, Borislav Petkov wrote: > On Fri, Sep 18, 2020 at 10:37:28AM +0800, Xiongfeng Wang wrote: > > Thansk a lot. I will send another version. Also I will change the > > 'snprintf' in 'dimmdev_location_show()' to 'scnprintf' > > No need to send another one - I have everything locally and just amended > it.
A generic question about sysfs is whether or not the PAGE_SIZE buf output should be newline terminated or not if an the buffer is completely filled and the desired output cannot be newline terminated.
Likely not.
NUL termination without newline should be enough to indicate overrun.
| |