Messages in this thread | | | Date | Fri, 18 Sep 2020 11:04:40 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 3/3] hwmon: (lm75) Add regulator support |
| |
On Thu, Sep 17, 2020 at 10:33:37PM -0700, Guenter Roeck wrote: > On 9/17/20 3:18 AM, Alban Bedel wrote:
> > + err = regulator_enable(data->vs);
> How about device removal ? Don't you have to call regulator_disable() > there as well ? If so, it might be best to use devm_add_action_or_reset() > to register a disable function.
Yes, disables should be balanced (and any attempt to unregister the regulator with references still held should result in a warning). [unhandled content-type:application/pgp-signature] | |