Messages in this thread | | | From | Alexander Potapenko <> | Date | Fri, 18 Sep 2020 11:44:43 +0200 | Subject | Re: [PATCH v2 20/37] kasan: rename tags.c to tags_sw.c |
| |
On Fri, Sep 18, 2020 at 11:41 AM Alexander Potapenko <glider@google.com> wrote: > > On Tue, Sep 15, 2020 at 11:17 PM Andrey Konovalov <andreyknvl@google.com> wrote: > > > > This is a preparatory commit for the upcoming addition of a new hardware > > tag-based (MTE-based) KASAN mode. > > > > Hardware tag-based KASAN will also be using tag-based approach, so rename > > tags.c to tags_sw.c and report_tags.c to report_tags_sw.c to avoid > > confusion once the new mode is added > > I find it a bit excessive renaming the same file twice in the same > patch series (tags_report.c -> report_tags.c -> report_tags_sw.c)
Also, as we are going to have CONFIG_KASAN_{SW,HW}_TAGS, won't it be better to call the files {report_,}tags_{sw,hw}.c ?
-- Alexander Potapenko Software Engineer
Google Germany GmbH Erika-Mann-Straße, 33 80636 München
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg
| |