lkml.org 
[lkml]   [2020]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] crypto: hisilicon/hpre - fix a bug in dh algorithm
From
Date
Yes, 'u64' is redundant,  I will resend one!
Thank you!


On 2020/9/18 15:11, Herbert Xu wrote:
> On Thu, Sep 10, 2020 at 07:25:22PM +0800, Meng Yu wrote:
>>
>> diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
>> index 0cbe99a1..2d91593 100644
>> --- a/drivers/crypto/hisilicon/hpre/hpre_crypto.c
>> +++ b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
>> @@ -528,6 +528,8 @@ static int hpre_dh_compute_value(struct kpp_request *req)
>> ret = hpre_hw_data_init(hpre_req, req->src, req->src_len, 1, 1);
>> if (unlikely(ret))
>> goto clear_all;
>> + } else {
>> + msg->in = cpu_to_le64((u64)ctx->dh.dma_g);
>
> Why do you need the u64 cast?
>
> Cheers,
>

\
 
 \ /
  Last update: 2020-09-18 10:45    [W:0.042 / U:1.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site