Messages in this thread | | | Subject | Re: [PATCH v2 2/2] mailbox: Add Broadcom STB mailbox driver | From | Randy Dunlap <> | Date | Fri, 18 Sep 2020 15:21:22 -0700 |
| |
Hi,
On 9/18/20 3:15 PM, Jim Quinlan wrote: > diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig > index 05b1009e2820..378ebd5a7933 100644 > --- a/drivers/mailbox/Kconfig > +++ b/drivers/mailbox/Kconfig > @@ -254,4 +254,16 @@ config QCOM_IPCC > acts as an interrupt controller for receiving interrupts from clients. > Say Y here if you want to build this driver. >
coding-style.rst says:
Lines under a ``config`` definition are indented with one tab, while help text is indented an additional two spaces.
so please fix up the "help" line and the next 2 lines under it.
> +config BRCMSTB_MBOX > + tristate "Broadcom STB Mailbox" > + depends on ARM64 || ARM > + depends on ARM_SCMI_PROTOCOL && ARCH_BRCMSTB > + default ARM_SCMI_PROTOCOL && ARCH_BRCMSTB > + help > + Mailbox implementation of the Broadcom STB for the sole purposes > + of SCMI communication. This is used by the SCMI drivers to > + communicate with FW that runs in EL3. This mailbox only implements > + the agent-to-platform channgel of SCMI but may be augmented in
channel
> + the future to add the platform-to-agent channel. > + > endif
thanks. -- ~Randy
| |