Messages in this thread | | | Date | Thu, 17 Sep 2020 18:40:48 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v2 1/8] x86/CPU/AMD: Save NodeId on AMD-based systems |
| |
On Thu, Sep 17, 2020 at 11:20:53AM -0500, Yazen Ghannam wrote: > But newer systems support CPUID Leaf 0xB, so cpu_die_id will get > explicitly set by detect_extended_topology(). The value set is > different from the AMD NodeId. And at that point I shied away from > doing any override or fixup.
Well, different how? Can you extract the node_id you need from CPUID(0xb)? If yes, we can do an AMD-specific branch in detect_extended_topology() but that better be future proof.
IOW, is information from CPUID(0xb) ever going to be needed in the kernel?
Also, and independently, if its definition do not give you the node_id you need, then you can just as well overwrite ->cpu_die_id in detect_extended_topology() because that value - whatever that is, could be garbage, just as well - is wrong on AMD anyway.
So it would be a fix for the leaf parsing, regardless of whether you need it or not.
Makes sense?
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |