lkml.org 
[lkml]   [2020]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] memory: Convert to DEFINE_SHOW_ATTRIBUTE
From
Date


在 2020/7/18 5:14, Pavel Machek 写道:
> On Thu 2020-07-16 17:03:03, Qinglang Miao wrote:
>> From: Yongqiang Liu <liuyongqiang13@huawei.com>
>>
>> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>>
>> Signed-off-by: Yongqiang Liu <liuyongqiang13@huawei.com>
>> ---
>> drivers/memory/emif.c | 22 ++--------------------
>> drivers/memory/tegra/tegra124-emc.c | 14 +-------------
>> 2 files changed, 3 insertions(+), 33 deletions(-)
>>
>> diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
>> index 58a82eea5..aab8ddad7 100644
>> --- a/drivers/memory/emif.c
>> +++ b/drivers/memory/emif.c
>> @@ -131,16 +131,7 @@ static int emif_regdump_show(struct seq_file *s, void *unused)
>> return 0;
>> }
>>
>> -static int emif_regdump_open(struct inode *inode, struct file *file)
>> -{
>> - return single_open(file, emif_regdump_show, inode->i_private);
>> -}
>> -
>> -static const struct file_operations emif_regdump_fops = {
>> - .open = emif_regdump_open,
>> - .read_iter = seq_read_iter,
>> - .release = single_release,
>> -};
>> +DEFINE_SHOW_ATTRIBUTE(emif_regdump);
>
> This is not equivalent (and I guess changelog should mention that).
>
> Along with other changes, we get:
>
> .owner = THIS_MODULE,
> .llseek = seq_lseek,
>
> . Is that okay thing to add?
> Pavel
>
Hi Pavel,

I've sent a new patch against linux-next(20200917), and it can
be applied to mainline cleanly now.

And your concerns are explained in commit log.

Thanks.

\
 
 \ /
  Last update: 2020-09-17 14:52    [W:0.048 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site