Messages in this thread Patch in this message | | | From | Huang Guobin <> | Subject | [PATCH -next] apparmor: Fix several kernel-doc warnings | Date | Thu, 17 Sep 2020 08:24:57 -0400 |
| |
Fixes the following W=1 kernel build warning(s):
security/apparmor/apparmorfs.c:2127: warning: Excess function parameter 'profile' description in '__next_profile' security/apparmor/domain.c:1292: warning: Excess function parameter 'onexec' description in 'aa_change_profile' security/apparmor/domain.c:136: warning: Excess function parameter 'start' description in 'label_compound_match'
Rename profile to p. @onexec in 'aa_change_profile' and @start in 'label_compound_match' are not in use, Remove it.
Signed-off-by: Huang Guobin <huangguobin4@huawei.com> --- security/apparmor/apparmorfs.c | 2 +- security/apparmor/domain.c | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c index 5fd4a64e431f..f00a372be7b6 100644 --- a/security/apparmor/apparmorfs.c +++ b/security/apparmor/apparmorfs.c @@ -2116,7 +2116,7 @@ static struct aa_profile *__first_profile(struct aa_ns *root, /** * __next_profile - step to the next profile in a profile tree - * @profile: current profile in tree (NOT NULL) + * @p: current profile in tree (NOT NULL) * * Perform a depth first traversal on the profile tree in a namespace * diff --git a/security/apparmor/domain.c b/security/apparmor/domain.c index f919ebd042fd..12a9d80cd63a 100644 --- a/security/apparmor/domain.c +++ b/security/apparmor/domain.c @@ -178,7 +178,6 @@ static int label_compound_match(struct aa_profile *profile, * @profile: profile to find perms for * @label: label to check access permissions for * @stack: whether this is a stacking request - * @start: state to start match in * @subns: whether to do permission checks on components in a subns * @request: permissions to request * @perms: an initialized perms struct to add accumulation to @@ -1277,14 +1276,11 @@ static int change_profile_perms_wrapper(const char *op, const char *name, /** * aa_change_profile - perform a one-way profile transition * @fqname: name of profile may include namespace (NOT NULL) - * @onexec: whether this transition is to take place immediately or at exec * @flags: flags affecting change behavior * * Change to new profile @name. Unlike with hats, there is no way * to change back. If @name isn't specified the current profile name is * used. - * If @onexec then the transition is delayed until - * the next exec. * * Returns %0 on success, error otherwise. */ -- 2.25.1
| |