Messages in this thread | | | From | linmiaohe <> | Subject | Re: [PATCH v2] nfs: remove incorrect fallthrough label | Date | Thu, 17 Sep 2020 06:21:13 +0000 |
| |
Nick Desaulniers <ndesaulniers@google.com> wrote: > There is no case after the default from which to fallthrough to. Clang will error in this case (unhelpfully without context, see link below) and GCC will with -Wswitch-unreachable. > >The previous commit should have just replaced the comment with a break statement. > >If we consider implicit fallthrough to be a design mistake of C, then all case statements should be terminated with one of the following >statements: >* break >* continue >* return >* __attribute__(__fallthrough__) >* goto (plz no) >* (call of function with __attribute__(__noreturn__)) > >Fixes: 2a1390c95a69 ("nfs: Convert to use the preferred fallthrough macro") >Link: https://bugs.llvm.org/show_bug.cgi?id=47539 >Suggested-by: Joe Perches <joe@perches.com> >Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> >---
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
| |