Messages in this thread | | | Date | Thu, 17 Sep 2020 14:06:14 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH v7 26/34] i2c: tegra: Factor out hardware initialization into separate function |
| |
On Wed, Sep 09, 2020 at 01:39:58AM +0300, Dmitry Osipenko wrote: > Factor out hardware initialization into a separate function from the probe > function. The only place where runtime PM needs to be resumed during probe > is the place of hardware initialization, hence it makes sense to factor > out it in order to have a bit cleaner error handling in tegra_i2c_probe(). > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/i2c/busses/i2c-tegra.c | 32 +++++++++++++++++++------------- > 1 file changed, 19 insertions(+), 13 deletions(-)
Not really sure this is worth it, but since I don't feel strongly, I'll leave this up to Wolfram to decide:
Acked-by: Thierry Reding <treding@nvidia.com> [unhandled content-type:application/pgp-signature] | |