Messages in this thread | | | Date | Thu, 17 Sep 2020 12:22:03 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] regmap: Add support for 12/20 register formatting |
| |
On Thu, Sep 17, 2020 at 08:31:54AM +0200, Ricardo Ribalda Delgado wrote: > On Wed, Sep 16, 2020 at 6:29 PM Mark Brown <broonie@kernel.org> wrote:
> > What exactly is the format you're trying to describe here? It sounds > > like there's two blocks of padding in here (I'm assuing that's what > > dummy means) but what's the exact arrangement here and what are the > > commands? It sounds like this might not work ideally with things like > > the cache code (if it makes things seems sparser than they are) and > > might not be obvious to someone looking at the datsheet.
> The format is
> XXXXCCCCAAAADDDDDDDDDDDDDDDDXXXX
> Where X is dont care, C is command, A is address and D is data bits. I
> Shall I add this to the commit message? I want to send a V2 anyway, > because I screwed up the identity (ribalda.com instead of kernel.org)
Yes, please. I was fairly sure it worked, it was just a question of if it was ideal for the format described. The only issue I can see with the above is that the users will need to left shift their data - on the face of it it would seem better to add a facility for padding the LSBs of the data field to the core so that users can just use the data field as documented. [unhandled content-type:application/pgp-signature] | |