Messages in this thread | | | Subject | Re: [PATCH v2 1/3] drm/panfrost: add support for vendor quirk | From | Steven Price <> | Date | Thu, 17 Sep 2020 11:29:05 +0100 |
| |
On 16/09/2020 16:01, Neil Armstrong wrote: > The T820, G31 & G52 GPUs integratewd by Amlogic in the respective GXM, G12A/SM1 & G12B
NIT: s/integratewd/integrated/
> SoCs needs a quirk in the PWR registers after each reset. > > This adds a callback in the device compatible struct of permit this. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Reviewed-by: Steven Price <steven.price@arm.com>
> --- > drivers/gpu/drm/panfrost/panfrost_device.h | 3 +++ > drivers/gpu/drm/panfrost/panfrost_gpu.c | 4 ++++ > 2 files changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_device.h b/drivers/gpu/drm/panfrost/panfrost_device.h > index abfc78db193a..140e004a3790 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_device.h > +++ b/drivers/gpu/drm/panfrost/panfrost_device.h > @@ -70,6 +70,9 @@ struct panfrost_compatible { > int num_pm_domains; > /* Only required if num_pm_domains > 1. */ > const char * const *pm_domain_names; > + > + /* Vendor implementation quirks callback */ > + void (*vendor_quirk)(struct panfrost_device *pfdev); > }; > > struct panfrost_device { > diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c > index c7c5da5a31d4..a6de78bc1fa8 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c > +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c > @@ -136,6 +136,10 @@ static void panfrost_gpu_init_quirks(struct panfrost_device *pfdev) > > if (quirks) > gpu_write(pfdev, GPU_JM_CONFIG, quirks); > + > + /* Here goes platform specific quirks */ > + if (pfdev->comp->vendor_quirk) > + pfdev->comp->vendor_quirk(pfdev); > } > > #define MAX_HW_REVS 6 >
| |