Messages in this thread | | | Date | Thu, 17 Sep 2020 18:54:50 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCHv3] perf kvm: add kvm-stat for arm64 |
| |
On (20/09/17 16:47), Leo Yan wrote: [..] > > +static void event_get_key(struct evsel *evsel, > > + struct perf_sample *sample, > > + struct event_key *key) > > +{ > > + key->info = 0; > > + key->key = perf_evsel__intval(evsel, sample, kvm_exit_reason); > > Now the perf/core branch doesn't have API perf_evsel__intval(), and it > has been replaced with evsel__intval(); so please > > s/perf_evsel__intval/evsel__intval
ACK. The kernel I'm using still have perf_evsel__intval().
> > + if (key->key == ARM_EXCEPTION_TRAP) { > > + key->key = perf_evsel__intval(evsel, sample, > > Ditto.
ACK. Sorry about that.
> Otherwise, this patch is good for me and I have tested this patch with > below commands: > > $ perf kvm stat record > $ perf kvm stat report
"perf kvm stat live" should also work.
> Reviewed-by: Leo Yan <leo.yan@linaro.org> > Tested-by: Leo Yan <leo.yan@linaro.org>
Thanks!
-ss
| |