lkml.org 
[lkml]   [2020]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 064/330] f2fs: stop GC when the victim becomes fully valid
    Date
    From: Jaegeuk Kim <jaegeuk@kernel.org>

    [ Upstream commit 803e74be04b32f7785742dcabfc62116718fbb06 ]

    We must stop GC, once the segment becomes fully valid. Otherwise, it can
    produce another dirty segments by moving valid blocks in the segment partially.

    Ramon hit no free segment panic sometimes and saw this case happens when
    validating reliable file pinning feature.

    Signed-off-by: Ramon Pantin <pantin@google.com>
    Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/f2fs/gc.c | 10 ++++++++--
    1 file changed, 8 insertions(+), 2 deletions(-)

    diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
    index e611d768efde3..a78aa5480454f 100644
    --- a/fs/f2fs/gc.c
    +++ b/fs/f2fs/gc.c
    @@ -1012,8 +1012,14 @@ next_step:
    block_t start_bidx;
    nid_t nid = le32_to_cpu(entry->nid);

    - /* stop BG_GC if there is not enough free sections. */
    - if (gc_type == BG_GC && has_not_enough_free_secs(sbi, 0, 0))
    + /*
    + * stop BG_GC if there is not enough free sections.
    + * Or, stop GC if the segment becomes fully valid caused by
    + * race condition along with SSR block allocation.
    + */
    + if ((gc_type == BG_GC && has_not_enough_free_secs(sbi, 0, 0)) ||
    + get_valid_blocks(sbi, segno, false) ==
    + sbi->blocks_per_seg)
    return submitted;

    if (check_valid_map(sbi, segno, off) == 0)
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-09-18 05:12    [W:4.033 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site