lkml.org 
[lkml]   [2020]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 273/330] fuse: update attr_version counter on fuse_notify_inval_inode()
    Date
    From: Miklos Szeredi <mszeredi@redhat.com>

    [ Upstream commit 5ddd9ced9aef6cfa76af27d384c17c9e2d610ce8 ]

    A GETATTR request can race with FUSE_NOTIFY_INVAL_INODE, resulting in the
    attribute cache being updated with stale information after the
    invalidation.

    Fix this by bumping the attribute version in fuse_reverse_inval_inode().

    Reported-by: Krzysztof Rusek <rusek@9livesdata.com>
    Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/fuse/inode.c | 7 +++++++
    1 file changed, 7 insertions(+)

    diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
    index 5dca643a257c9..f58ab84b09fb3 100644
    --- a/fs/fuse/inode.c
    +++ b/fs/fuse/inode.c
    @@ -323,6 +323,8 @@ struct inode *fuse_iget(struct super_block *sb, u64 nodeid,
    int fuse_reverse_inval_inode(struct super_block *sb, u64 nodeid,
    loff_t offset, loff_t len)
    {
    + struct fuse_conn *fc = get_fuse_conn_super(sb);
    + struct fuse_inode *fi;
    struct inode *inode;
    pgoff_t pg_start;
    pgoff_t pg_end;
    @@ -331,6 +333,11 @@ int fuse_reverse_inval_inode(struct super_block *sb, u64 nodeid,
    if (!inode)
    return -ENOENT;

    + fi = get_fuse_inode(inode);
    + spin_lock(&fi->lock);
    + fi->attr_version = atomic64_inc_return(&fc->attr_version);
    + spin_unlock(&fi->lock);
    +
    fuse_invalidate_attr(inode);
    forget_all_cached_acls(inode);
    if (offset >= 0) {
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-09-18 04:58    [W:4.308 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site