lkml.org 
[lkml]   [2020]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 272/330] fuse: don't check refcount after stealing page
    Date
    From: Miklos Szeredi <mszeredi@redhat.com>

    [ Upstream commit 32f98877c57bee6bc27f443a96f49678a2cd6a50 ]

    page_count() is unstable. Unless there has been an RCU grace period
    between when the page was removed from the page cache and now, a
    speculative reference may exist from the page cache.

    Reported-by: Matthew Wilcox <willy@infradead.org>
    Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/fuse/dev.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
    index 06dd38e76c62a..f9022b7028754 100644
    --- a/fs/fuse/dev.c
    +++ b/fs/fuse/dev.c
    @@ -764,7 +764,6 @@ static int fuse_check_page(struct page *page)
    {
    if (page_mapcount(page) ||
    page->mapping != NULL ||
    - page_count(page) != 1 ||
    (page->flags & PAGE_FLAGS_CHECK_AT_PREP &
    ~(1 << PG_locked |
    1 << PG_referenced |
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-09-18 04:58    [W:6.292 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site