lkml.org 
[lkml]   [2020]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 020/206] mtd: cfi_cmdset_0002: don't free cfi->cfiq in error path of cfi_amdstd_setup()
    Date
    From: Hou Tao <houtao1@huawei.com>

    [ Upstream commit 03976af89e3bd9489d542582a325892e6a8cacc0 ]

    Else there may be a double-free problem, because cfi->cfiq will
    be freed by mtd_do_chip_probe() if both the two invocations of
    check_cmd_set() return failure.

    Signed-off-by: Hou Tao <houtao1@huawei.com>
    Reviewed-by: Richard Weinberger <richard@nod.at>
    Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mtd/chips/cfi_cmdset_0002.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
    index 1dbc9554a0786..3ab75d3e2ce32 100644
    --- a/drivers/mtd/chips/cfi_cmdset_0002.c
    +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
    @@ -727,7 +727,6 @@ static struct mtd_info *cfi_amdstd_setup(struct mtd_info *mtd)
    kfree(mtd->eraseregions);
    kfree(mtd);
    kfree(cfi->cmdset_priv);
    - kfree(cfi->cfiq);
    return NULL;
    }

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-09-18 04:51    [W:5.473 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site